Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 64DB9200D12 for ; Sat, 23 Sep 2017 01:20:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6360C1609E5; Fri, 22 Sep 2017 23:20:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA7531609D0 for ; Sat, 23 Sep 2017 01:20:05 +0200 (CEST) Received: (qmail 33810 invoked by uid 500); 22 Sep 2017 23:20:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 33764 invoked by uid 99); 22 Sep 2017 23:20:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 23:20:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4F31FCD253 for ; Fri, 22 Sep 2017 23:20:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NqCJ11HL7CCw for ; Fri, 22 Sep 2017 23:20:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id BFE365FB2E for ; Fri, 22 Sep 2017 23:20:00 +0000 (UTC) Received: (qmail 31249 invoked by uid 99); 22 Sep 2017 23:19:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 23:19:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8C0D3E0AF6; Fri, 22 Sep 2017 23:19:59 +0000 (UTC) From: bowenli86 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4701: [FLINK-7664] Replace FlinkFutureException by java.... Content-Type: text/plain Message-Id: <20170922231959.8C0D3E0AF6@git1-us-west.apache.org> Date: Fri, 22 Sep 2017 23:19:59 +0000 (UTC) archived-at: Fri, 22 Sep 2017 23:20:06 -0000 Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4701#discussion_r140614369 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java --- @@ -65,7 +65,7 @@ public JarPlanHandler(Executor executor, File jarDirectory) { return writer.toString(); } catch (Exception e) { - throw new FlinkFutureException(e); + throw new CompletionException(e); --- End diff -- Why it's not wrapping a `FlinkException` here? ---