Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 612BF200CF8 for ; Thu, 14 Sep 2017 14:17:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 601F41609CD; Thu, 14 Sep 2017 12:17:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A6B421609CC for ; Thu, 14 Sep 2017 14:17:07 +0200 (CEST) Received: (qmail 4715 invoked by uid 500); 14 Sep 2017 12:17:05 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 4706 invoked by uid 99); 14 Sep 2017 12:17:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Sep 2017 12:17:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E9AC8D097F for ; Thu, 14 Sep 2017 12:17:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kn1vuNRLwAcP for ; Thu, 14 Sep 2017 12:17:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5FC6E5FB4E for ; Thu, 14 Sep 2017 12:17:02 +0000 (UTC) Received: (qmail 4213 invoked by uid 99); 14 Sep 2017 12:17:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Sep 2017 12:17:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 87DA4F5593; Thu, 14 Sep 2017 12:17:01 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4668: [FLINK-7617] Remove string format in BitSet to imp... Content-Type: text/plain Message-Id: <20170914121701.87DA4F5593@git1-us-west.apache.org> Date: Thu, 14 Sep 2017 12:17:01 +0000 (UTC) archived-at: Thu, 14 Sep 2017 12:17:08 -0000 Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4668#discussion_r138875420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java --- @@ -56,8 +56,7 @@ public void setMemorySegment(MemorySegment memorySegment, int offset) { * @param index - position */ public void set(int index) { - Preconditions.checkArgument(index < bitLength && index >= 0, - String.format("Input Index[%d] is larger than BitSet available size[%d].", index, bitLength)); + Preconditions.checkArgument(index < bitLength && index >= 0); --- End diff -- Can be changed to ``` Preconditions.checkArgument(index < bitLength && index >= 0, "Input Index[%d] is larger than BitSet available size[%d].", index, bitLength); ``` to perserve the error message. ---