Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E2D4A200CFA for ; Tue, 5 Sep 2017 23:50:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E1592160E16; Tue, 5 Sep 2017 21:50:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 335891609E7 for ; Tue, 5 Sep 2017 23:50:25 +0200 (CEST) Received: (qmail 65887 invoked by uid 500); 5 Sep 2017 21:50:23 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 65878 invoked by uid 99); 5 Sep 2017 21:50:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2017 21:50:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 49176D50DE for ; Tue, 5 Sep 2017 21:50:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.02 X-Spam-Level: X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PahjNE_CsM4F for ; Tue, 5 Sep 2017 21:50:19 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 805B36126F for ; Tue, 5 Sep 2017 21:50:18 +0000 (UTC) Received: (qmail 65408 invoked by uid 99); 5 Sep 2017 21:50:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2017 21:50:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EFFE9F561A; Tue, 5 Sep 2017 21:50:17 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i... Content-Type: text/plain Message-Id: <20170905215017.EFFE9F561A@git1-us-west.apache.org> Date: Tue, 5 Sep 2017 21:50:17 +0000 (UTC) archived-at: Tue, 05 Sep 2017 21:50:26 -0000 Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137123724 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -232,4 +232,164 @@ class JoinHarnessTest extends HarnessTestBase{ testHarness.close() } + /** a.proctime >= b.proctime - 10 and a.proctime <= b.proctime + 20 **/ + @Test + def testNewNormalProcTimeJoin() { --- End diff -- We would also need harness tests for the event-time join. In addition we need: - plan translation tests (see `org.apache.flink.table.api.stream.sql.JoinTest`) - some end-to-end ITCases (see `org.apache.flink.table.runtime.stream.sql.JoinITCase` but with result validation) Moreover, the processing time restriction for windowed joins should be removed from the documentation. ---