flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bowenli86 <...@git.apache.org>
Subject [GitHub] flink pull request #4708: [FLINK-7393][kinesis connector] Move unit tests th...
Date Fri, 22 Sep 2017 23:15:58 GMT
GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4708

    [FLINK-7393][kinesis connector] Move unit tests that should belong to KinesisConfigUtil
from FlinkKinesisConsumerTest to KinesisConfigUtilTest

    ## What is the purpose of the change
    
    Right now, `FlinkKinesisConsumerTest` has lots of unit tests that actually should belong
to `KinesisConfigUtil`, e.g. all the `validateXxxConfiguration()`
    
    We need to move those tests out to a new file `KinesisConfigUtilTest`
    
    ## Brief change log
    
    - Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest
to KinesisConfigUtilTest
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-7223

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4708
    
----
commit 8ba44053ea96220fd74a357ff612bebf65553cb7
Author: Bowen Li <bowenli86@gmail.com>
Date:   2017-09-22T23:10:56Z

    FLINK-7393 Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest

----


---

Mime
View raw message