flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7635) Support sideOutput in ProcessWindowFunciton
Date Fri, 22 Sep 2017 15:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176606#comment-16176606
] 

ASF GitHub Bot commented on FLINK-7635:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4702#discussion_r140529325
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
    @@ -774,6 +774,14 @@ public KeyedStateStore windowState() {
     		public KeyedStateStore globalState() {
     			return WindowOperator.this.getKeyedStateStore();
     		}
    +
    +		public <X> void output(OutputTag<X> outputTag, X value) {
    +			if (outputTag == null) {
    +				throw new IllegalArgumentException("OutputTag must not be null.");
    +			}
    +			output.collect(outputTag, new StreamRecord<>(value, cleanupTime(window)));
    --- End diff --
    
    I think this should be `window.maxTimestamp()` to match `emitWindowContents()`.


> Support sideOutput in ProcessWindowFunciton
> -------------------------------------------
>
>                 Key: FLINK-7635
>                 URL: https://issues.apache.org/jira/browse/FLINK-7635
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API, Scala API
>            Reporter: Chen Qin
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.4.0, 1.3.3
>
>
> [FLINK-4460|https://issues.apache.org/jira/browse/FLINK-4460] only implemented output
to ProcessFunction Context. It would be nice to add support to ProcessWindow and ProcessAllWindow
functions as well. [email threads|http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/question-on-sideoutput-from-ProcessWindow-function-td15500.html]
> [~aljoscha] I thought this is good warm up task for ppl to learn how window function
works in general. Otherwise feel free to assign back to me.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message