flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable
Date Mon, 18 Sep 2017 08:44:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169757#comment-16169757

Fabian Hueske commented on FLINK-7627:

I don't have concerns that {{SingleElementIterable}} implements {{Serializable}} but I'd like
to understand the situation in which this leads to a problem.

If I see the code correctly, {{SingleElementIterable}} is only used in the generated code
for aggregations which is compiled on the worker nodes when the {{open()}} method of the wrapper
functions is called. Hence, it is not serialized when the function is shipped to the worker.
Also it is not serialized during checkpoints because we only need to serialize the accumulators
but not the generated class.

[~hequn8128] Can you explain when this leads to a problem? IMO, we should add a test to guard
such situations.

> SingleElementIterable should implement with Serializable 
> ---------------------------------------------------------
>                 Key: FLINK-7627
>                 URL: https://issues.apache.org/jira/browse/FLINK-7627
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
> {{SingleElementIterable}} is used to merge accumulators and it should be serializable
considering that it will be serialized when doing checkpoint.

This message was sent by Atlassian JIRA

View raw message