flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable
Date Fri, 15 Sep 2017 04:41:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167317#comment-16167317
] 

ASF GitHub Bot commented on FLINK-7627:
---------------------------------------

GitHub user hequn8128 opened a pull request:

    https://github.com/apache/flink/pull/4674

    [FLINK-7627] [table] SingleElementIterable should implement with Serializable

    
    ## What is the purpose of the change
    
    *This pull request is a bugfix which implements `SingleElementIterable` with `Serializable`*
    
    
    ## Brief change log
    
      - *Implement SingleElementIterable with Serializable*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Added test that validates that `SingleElementIterable` can be serialized, otherwise
exceptions will be throwed*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no )
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hequn8128/flink 7627

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4674
    
----
commit b1af2d612265f0727048388fea7695f42ba897cd
Author: 军长 <hequn.chq@alibaba-inc.com>
Date:   2017-09-15T03:10:49Z

    [FLINK-7627] [table] SingleElementIterable should implement with Serializable

----


> SingleElementIterable should implement with Serializable 
> ---------------------------------------------------------
>
>                 Key: FLINK-7627
>                 URL: https://issues.apache.org/jira/browse/FLINK-7627
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>
> {{SingleElementIterable}} is used to merge accumulators and it should be serializable
considering that it will be serialized when doing checkpoint.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message