flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL
Date Tue, 26 Sep 2017 16:44:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181117#comment-16181117
] 

ASF GitHub Bot commented on FLINK-7491:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4585#discussion_r141105482
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala
---
    @@ -0,0 +1,158 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.functions.aggfunctions
    +
    +import java.lang.{Iterable => JIterable}
    +import java.util
    +import java.util.function.BiFunction
    +
    +import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
    +import org.apache.flink.api.java.typeutils._
    +import org.apache.flink.table.api.dataview.MapView
    +import org.apache.flink.table.dataview.MapViewTypeInfo
    +import org.apache.flink.table.functions.AggregateFunction
    +
    +
    +/** The initial accumulator for Collect aggregate function */
    +class CollectAccumulator[E](var f0:MapView[E, Integer]) {
    +  def this() {
    +    this(null)
    +  }
    +
    +  def canEqual(a: Any) = a.isInstanceOf[CollectAccumulator[E]]
    +
    +  override def equals(that: Any): Boolean =
    +    that match {
    +      case that: CollectAccumulator[E] => that.canEqual(this) && this.f0 ==
that.f0
    +      case _ => false
    +    }
    +}
    +
    +abstract class CollectAggFunction[E]
    +  extends AggregateFunction[util.Map[E, Integer], CollectAccumulator[E]] {
    +
    +  override def createAccumulator(): CollectAccumulator[E] = {
    +    val acc = new CollectAccumulator[E](new MapView[E, Integer](
    +      getValueTypeInfo.asInstanceOf[TypeInformation[E]], BasicTypeInfo.INT_TYPE_INFO))
    +    acc
    +  }
    +
    +  def accumulate(accumulator: CollectAccumulator[E], value: E): Unit = {
    +    if (value != null) {
    --- End diff --
    
    If yes, we would need to check if `MapView` supports `null` keys. If not we could wrap
the key in a Row of arity 1 because Row supports null serialization.


> Support COLLECT Aggregate function in Flink SQL
> -----------------------------------------------
>
>                 Key: FLINK-7491
>                 URL: https://issues.apache.org/jira/browse/FLINK-7491
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message