flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7489) Remove job lifecycle methods from public JobMasterGateway interface
Date Sun, 03 Sep 2017 21:05:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151957#comment-16151957
] 

ASF GitHub Bot commented on FLINK-7489:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4573
  
    Failing test cases are unrelated. Merging this PR.


> Remove job lifecycle methods from public JobMasterGateway interface
> -------------------------------------------------------------------
>
>                 Key: FLINK-7489
>                 URL: https://issues.apache.org/jira/browse/FLINK-7489
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> The {{JobMaster}} exposes its job lifecycle methods {{startJobExecution}} and {{suspendExecution}}
via its {{JobMasterGateway}} to the public. I think these methods should not be exposed because
it allows other components to affect the job execution without proper reason. Only the {{JobManagerRunner}}
should be responsible for calling these methods and has direct access to the {{JobMaster}}
instance. Therefore, these methods can directly be implemented by the {{JobMaster}} without
exposing them via the {{JobMasterGateway}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message