flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource
Date Mon, 25 Sep 2017 14:04:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179068#comment-16179068
] 

ASF GitHub Bot commented on FLINK-7446:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4710#discussion_r140776048
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/PushProjectIntoTableSourceScanRule.scala
---
    @@ -33,6 +32,9 @@ class PushProjectIntoTableSourceScanRule extends RelOptRule(
       override def matches(call: RelOptRuleCall): Boolean = {
         val scan: FlinkLogicalTableSourceScan = call.rel(1).asInstanceOf[FlinkLogicalTableSourceScan]
         scan.tableSource match {
    +      // projection pushdown is not supported for sources that provide time indicators
    +      case r: DefinedRowtimeAttribute if r.getRowtimeAttribute != null => false
    --- End diff --
    
    Can you create a follow-up issue for this?


> Support to define an existing field as the rowtime field for TableSource
> ------------------------------------------------------------------------
>
>                 Key: FLINK-7446
>                 URL: https://issues.apache.org/jira/browse/FLINK-7446
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Fabian Hueske
>
> Currently {{DefinedRowtimeAttribute}} can define an appended rowtime field for a {{TableSource}}.
But it would be helpful if we can support to define an existing field as the rowtime field.
Just like registering a DataStream, the rowtime field can be appended but also can replace
an existing field.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message