flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7394) Manage exclusive buffers in RemoteInputChannel
Date Mon, 25 Sep 2017 16:04:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179226#comment-16179226
] 

ASF GitHub Bot commented on FLINK-7394:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4499#discussion_r140809272
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -70,6 +78,15 @@
     	 */
     	private int expectedSequenceNumber = 0;
     
    +	/** The initial number of exclusive buffers assigned to this channel. */
    +	private int initialCredit;
    +
    +	/** The current available buffers including both exclusive buffers and requested floating
buffers. */
    +	private final ArrayDeque<Buffer> availableBuffers = new ArrayDeque<>();
    +
    +	/** The number of available buffers that have not been unannounced to producer yet.
*/
    --- End diff --
    
    actually, there were some more typos here - the full comment should be something like
this `The number of available buffers that have not been announced to the producer yet.`


> Manage exclusive buffers in RemoteInputChannel
> ----------------------------------------------
>
>                 Key: FLINK-7394
>                 URL: https://issues.apache.org/jira/browse/FLINK-7394
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control. 
> The basic works are:
> * Exclusive buffers are assigned to {{RemoteInputChannel}} after created by {{SingleInputGate}}.
> * {{RemoteInputChannel}} implements {{BufferRecycler}} interface to manage the exclusive
buffers itself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message