flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic
Date Fri, 15 Sep 2017 09:16:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167587#comment-16167587
] 

ASF GitHub Bot commented on FLINK-7394:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4499#discussion_r136027041
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
    @@ -281,6 +284,67 @@ public void testProducerFailedException() throws Exception {
     		ch.getNextBuffer();
     	}
     
    +	@Test
    +	public void testNotifyCreditOnBufferRecycling() throws Exception {
    +		// Setup
    +		final SingleInputGate inputGate = mock(SingleInputGate.class);
    +		final PartitionRequestClient client = mock(PartitionRequestClient.class);
    +		final RemoteInputChannel inputChannel = createRemoteInputChannel(inputGate, client,
new Tuple2<>(0, 0));
    +
    +		inputChannel.requestSubpartition(0);
    +
    +		// Recycle exclusive segment
    +		inputChannel.recycle(HeapMemorySegment.FACTORY.allocateUnpooledSegment(1024, inputChannel));
    --- End diff --
    
    why not use the more generic `MemorySegmentFactory.getFactory()`?


> Implement basic InputChannel for credit-based logic
> ---------------------------------------------------
>
>                 Key: FLINK-7394
>                 URL: https://issues.apache.org/jira/browse/FLINK-7394
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control. 
> The basic works are:
> * Propose the {{BufferListener}} interface for notifying buffer availability and buffer
destroyed.
> * {{RemoteInputChannel}} implements {{BufferRecycler}} interface to manage the exclusive
buffers itself.
> * {{RemoteInputChannel}} implements {{BufferListener}} interface to be notified repeatedly
.
> * {{RemoteInputChannel}} maintains and notifies of unannounced credit.
> * {{RemoteInputChannel}} maintains current sender backlog to trigger requests of floating
buffers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message