flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs
Date Wed, 20 Sep 2017 12:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173108#comment-16173108
] 

ASF GitHub Bot commented on FLINK-7068:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r139957010
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -174,7 +176,6 @@ public ServerSocket createSocket(int port) throws IOException {
     		// start the server thread
     		setName("BLOB Server listener at " + getPort());
     		setDaemon(true);
    -		start();
    --- End diff --
    
    Basically yes but this pattern does not work well with classes inheriting from `BlobServer`.
Here, this is only the case for the `TestingFailingBlobServer` which sets additional properties
and relies on them being set while executing `run()`. If started in the constructor, the `run()`
method would work on a partially initialised object.


> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>
>                 Key: FLINK-7068
>                 URL: https://issues.apache.org/jira/browse/FLINK-7068
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are permanently stored
for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc. which even
does not have to be reflected by files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message