flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs
Date Wed, 20 Sep 2017 12:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173100#comment-16173100

ASF GitHub Bot commented on FLINK-7068:

Github user NicoK commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -415,13 +393,17 @@ private BlobKey putBuffer(@Nullable JobID jobId, byte[] value, int
offset, int l
     	 * 		the ID of the job the BLOB belongs to (or <tt>null</tt> if job-unrelated)
     	 * @param inputStream
     	 * 		the input stream to read the data from
    +	 * @param permanentBlob
    +	 * 		whether the BLOB is permanent (<tt>true</tt>) or transient (<tt>false</tt>)
     	 * @return the computed BLOB key of the uploaded BLOB
     	 * @throws IOException
     	 * 		thrown if an I/O error occurs while uploading the data to the BLOB server
    -	private BlobKey putInputStream(@Nullable JobID jobId, InputStream inputStream) throws
IOException {
    +	BlobKey putInputStream(@Nullable JobID jobId, InputStream inputStream, boolean permanentBlob)
    --- End diff --
    I'm not sure, it's worth it since this method is about to become private to `TransientBlobCache`
once the BLOB upload is not necessary from the client anymore, i.e. once we upload the job
in a single (HTTP) operation

> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>                 Key: FLINK-7068
>                 URL: https://issues.apache.org/jira/browse/FLINK-7068
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are permanently stored
for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc. which even
does not have to be reflected by files.

This message was sent by Atlassian JIRA

View raw message