flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6893) Add BIN supported in SQL
Date Sun, 24 Sep 2017 00:12:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178014#comment-16178014
] 

ASF GitHub Bot commented on FLINK-6893:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4128#discussion_r140644236
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
    @@ -33,6 +33,14 @@ object ScalarSqlFunctions {
         OperandTypes.NILADIC,
         SqlFunctionCategory.NUMERIC)
     
    +  val BIN = new SqlFunction(
    +    "BIN",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.explicit(SqlTypeName.VARCHAR),
    +    null,
    +    OperandTypes.NUMERIC,
    --- End diff --
    
    Yes, In current code we only support BYTE,SHORT,INTEGER,LONG. If we try to using a FLOAT
input we will got the EXCEPTION. 
    If understand you correctly you want define a new operand types checker, just like `tableAPI(ScalarSqlFunction)`,
But I in SQL I'd better using CALCITE's default `OperandTypeChecker`. What do you think?


> Add BIN supported in SQL
> ------------------------
>
>                 Key: FLINK-6893
>                 URL: https://issues.apache.org/jira/browse/FLINK-6893
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> BIN(N) Returns a string representation of the binary value of N, where N is a longlong
(BIGINT) number. This is equivalent to CONV(N,10,2). Returns NULL if N is NULL.
> * Syntax:
> BIN(num)
> * Arguments
> **num: a long/bigint value
> * Return Types
>   String
> * Example:
>   BIN(12) -> '1100'
> * See more:
> ** [MySQL| https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_bin]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message