flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mingleizhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests
Date Mon, 25 Sep 2017 01:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178428#comment-16178428
] 

mingleizhang commented on FLINK-6444:
-------------------------------------

Hey, [~yew1eb]. I think you can just use reflections do it in a simple way. And I guess it
is more easier than your method as it is just a insignificant change. Not suggest to write
many codes for it. And it will take potential bug instead probably.

> Add a check that '@VisibleForTesting' methods are only used in tests
> --------------------------------------------------------------------
>
>                 Key: FLINK-6444
>                 URL: https://issues.apache.org/jira/browse/FLINK-6444
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: mingleizhang
>
> Some methods are annotated with {{@VisibleForTesting}}. These methods should only be
called from tests.
> This is currently not enforced / checked during the build. We should add such a check.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message