flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Rohrmann (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-2395) Check Scala catch blocks for Throwable
Date Wed, 13 Sep 2017 21:11:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Till Rohrmann closed FLINK-2395.
--------------------------------
    Resolution: Won't Fix

> Check Scala catch blocks for Throwable
> --------------------------------------
>
>                 Key: FLINK-2395
>                 URL: https://issues.apache.org/jira/browse/FLINK-2395
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Scala API
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> As described in [1], it's not a good practice to catch {{Throwables}} in Scala catch
blocks because Scala uses some special exceptions for the control flow. Therefore we should
check whether we can restrict ourselves to only catching subtypes of {{Throwable}}, such as
{{Exception}}, instead.
> [1] https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message