flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bowenli86 <...@git.apache.org>
Subject [GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...
Date Fri, 29 Sep 2017 19:13:14 GMT
Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4509#discussion_r141945843
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
    @@ -235,14 +240,15 @@ void releaseBuffer() {
     		ByteBuf write(ByteBufAllocator allocator) throws IOException {
     			checkNotNull(buffer, "No buffer instance to serialize.");
     
    -			int length = 16 + 4 + 1 + 4 + buffer.getSize();
    +			int length = 16 + 4 + 4 + 1 + 4 + buffer.getSize();
    --- End diff --
    
    can you please add a comment here explaining reasons of the math?


---

Mime
View raw message