flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...
Date Wed, 27 Sep 2017 14:30:16 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4728#discussion_r141348426
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/JobConfigHandler.java
---
    @@ -42,7 +42,7 @@
     
     	private static final String JOB_CONFIG_REST_PATH = "/jobs/:jobid/config";
     
    -	public JobConfigHandler(ExecutionGraphHolder executionGraphHolder, Executor executor)
{
    +	public JobConfigHandler(ExecutionGraphCache executionGraphHolder, Executor executor)
{
    --- End diff --
    
    nit: would be nice to update the variable name also to be consistent:
    `executionGraphHolder` -> `executionGraphCache`


---

Mime
View raw message