flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #4697: [FLINK-7650] [flip6] Port JobCancellationHandler to new R...
Date Wed, 27 Sep 2017 13:31:34 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4697
  
    I see a few problems with separating running&completed jobs.
    
    * The monitoring pattern for a job becomes quite weird. While a job is running you ask
"/jobs/running/:jobid", until you get a 404 and then check "/jobs/completed/:jobid".
    * Submitting a job is a POST to "/jobs", which returns "/jobs/running/:jobid" which may
return a 404 if the job fails straight away.
    * A unified URL allows us to actually provide good error messages, i.e. a 405 Method not
Allowed when trying to take a savepoint for finished jobs. For separate URLs this would return
a 404.
    * We have to handle the case of a savepoint/stop request arriving for the finished job
anyway, if the job finishes between accepting the request and handling it.
    
    Given that it only affects taking savepoints and stopping a job i don't think it's really
necessary to change things. Note that if we were to do that the job termination should probably
be a POST instead.


---

Mime
View raw message