flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4499: [FLINK-7394][core] Manage exclusive buffers in Rem...
Date Mon, 25 Sep 2017 16:03:12 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4499#discussion_r140809272
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -70,6 +78,15 @@
     	 */
     	private int expectedSequenceNumber = 0;
     
    +	/** The initial number of exclusive buffers assigned to this channel. */
    +	private int initialCredit;
    +
    +	/** The current available buffers including both exclusive buffers and requested floating
buffers. */
    +	private final ArrayDeque<Buffer> availableBuffers = new ArrayDeque<>();
    +
    +	/** The number of available buffers that have not been unannounced to producer yet.
*/
    --- End diff --
    
    actually, there were some more typos here - the full comment should be something like
this `The number of available buffers that have not been announced to the producer yet.`


---

Mime
View raw message