flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4710: [FLINK-7446] [table] Change DefinedRowtimeAttribut...
Date Mon, 25 Sep 2017 14:03:47 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4710#discussion_r140776048
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/PushProjectIntoTableSourceScanRule.scala
---
    @@ -33,6 +32,9 @@ class PushProjectIntoTableSourceScanRule extends RelOptRule(
       override def matches(call: RelOptRuleCall): Boolean = {
         val scan: FlinkLogicalTableSourceScan = call.rel(1).asInstanceOf[FlinkLogicalTableSourceScan]
         scan.tableSource match {
    +      // projection pushdown is not supported for sources that provide time indicators
    +      case r: DefinedRowtimeAttribute if r.getRowtimeAttribute != null => false
    --- End diff --
    
    Can you create a follow-up issue for this?


---

Mime
View raw message