flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aitozi <...@git.apache.org>
Subject [GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...
Date Sat, 23 Sep 2017 14:50:25 GMT
Github user Aitozi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4665#discussion_r140635202
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
    @@ -231,6 +231,8 @@ public void merge(W mergeResult,
     		// windowAssigner is event time and current timestamp + allowed lateness no less than
element timestamp
     		if (isSkippedElement && lateDataOutputTag != null && isElementLate(element))
{
    --- End diff --
    
    i think it should write in  this way  
    
    ```
                  if (isSkippedElement && isElementLate(element)) {
    			if (lateDataOutputTag != null){
    				sideOutput(element);
    			} else {
    				this.lostDataCount.inc();
    			}
    		}
    ```


---

Mime
View raw message