flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...
Date Thu, 21 Sep 2017 13:08:01 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4571#discussion_r140235301
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
    @@ -391,5 +391,8 @@ public void run() {
     		Future<?> cancelFuture = jm.ask(new JobManagerMessages.CancelJob(jobId), deadline.timeLeft());
     		Object response = Await.result(cancelFuture, deadline.timeLeft());
     		assertTrue("Unexpected response: " + response, response instanceof JobManagerMessages.CancellationSuccess);
    +
    +		// make sure, the execution is finished to not influence other test methods
    +		invokeThread.join(deadline.timeLeft().toMillis());
    --- End diff --
    
    makes sense, absolutely


---

Mime
View raw message