flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4674: [FLINK-7627] [table] SingleElementIterable should ...
Date Mon, 18 Sep 2017 08:45:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4674#discussion_r139364586
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/types/SingleElementIterableTest.scala
---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.runtime.types
    +
    +import org.apache.flink.table.functions.aggfunctions.IntegralAvgAccumulator
    +import org.apache.flink.table.runtime.aggregate.SingleElementIterable
    +import org.apache.flink.util.InstantiationUtil
    +import org.junit.Test
    +
    +class SingleElementIterableTest {
    --- End diff --
    
    I don't think we need a test to check for serializability of a class. 
    We should rather add a test case for the situation in which a non-serializable `SingleElementIterable`
leads to a problem.
    
    What do you think @hequn8128?


---

Mime
View raw message