flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4660: [FLINK-7050][table] Add support of RFC compliant C...
Date Sat, 16 Sep 2017 22:21:59 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4660#discussion_r139295101
  
    --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/batch/io/RFCCsvInputFormat.java
---
    @@ -0,0 +1,449 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.runtime.batch.io;
    +
    +import org.apache.flink.annotation.Internal;
    +import org.apache.flink.api.common.io.FileInputFormat;
    +import org.apache.flink.api.common.io.ParseException;
    +import org.apache.flink.core.fs.FileInputSplit;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.types.parser.FieldParser;
    +import org.apache.flink.util.Preconditions;
    +import org.apache.flink.util.StringUtils;
    +
    +import com.fasterxml.jackson.databind.MappingIterator;
    +import com.fasterxml.jackson.dataformat.csv.CsvMapper;
    +import com.fasterxml.jackson.dataformat.csv.CsvParser;
    +import com.fasterxml.jackson.dataformat.csv.CsvSchema;
    +
    +import org.apache.commons.io.input.BoundedInputStream;
    +
    +import java.io.IOException;
    +import java.sql.Date;
    +import java.sql.Time;
    +import java.sql.Timestamp;
    +import java.util.ArrayList;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +/**
    + * InputFormat that reads csv files and compliant with RFC 4180 standards.
    + *
    + * @param <OUT>
    + */
    +@Internal
    +public abstract class RFCCsvInputFormat<OUT> extends FileInputFormat<OUT>
{
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	public static final String DEFAULT_LINE_DELIMITER = "\n";
    +
    +	public static final String DEFAULT_FIELD_DELIMITER = ",";
    +
    +	private String recordDelimiter = "\n";
    +	private char fieldDelimiter = ',';
    +
    +	private boolean skipFirstLineAsHeader;
    +	private boolean skipFirstLine = false; // only for first split
    +
    +	private boolean quotedStringParsing = false;
    +	private char quoteCharacter;
    +
    +	private boolean lenient;
    +
    +	private String commentPrefix = null;
    +	private boolean allowComments = false;
    +
    +	private static final Class<?>[] EMPTY_TYPES = new Class<?>[0];
    +
    +	private static final boolean[] EMPTY_INCLUDED = new boolean[0];
    +
    +	private Class<?>[] fieldTypes = EMPTY_TYPES;
    +
    +	private boolean[] fieldIncluded = EMPTY_INCLUDED;
    +
    +	MappingIterator<Object[]> recordIterator = null;
    +
    +	private boolean endOfSplit = false;
    +
    +	protected RFCCsvInputFormat(Path filePath) {
    +		super(filePath);
    +	}
    +
    +	@Override
    +	public void open(FileInputSplit split) throws IOException {
    +
    +		super.open(split);
    +
    +		CsvMapper mapper = new CsvMapper();
    +		mapper.disable(CsvParser.Feature.WRAP_AS_ARRAY);
    +
    +		long firstDelimiterPosition = findFirstDelimiterPosition();
    +		long lastDelimiterPosition = findLastDelimiterPosition();
    +		long startPos = this.splitStart + firstDelimiterPosition;
    +		long endPos = this.splitLength + lastDelimiterPosition - firstDelimiterPosition;
    +		this.stream.seek(startPos);
    +		BoundedInputStream boundedInputStream = new BoundedInputStream(this.stream, endPos);
    +
    +		if (skipFirstLineAsHeader && startPos == 0) {
    +			skipFirstLine = true;
    +		}
    +
    +		CsvParser csvParser = mapper.getFactory().createParser(boundedInputStream);
    +		CsvSchema csvSchema = configureParserSettings();
    +		csvParser.setSchema(csvSchema);
    +
    +		recordIterator = mapper.readerFor(Object[].class).readValues(csvParser);
    +	}
    +
    +	private CsvSchema configureParserSettings() {
    +
    +		CsvSchema csvSchema = CsvSchema.builder()
    +			.setLineSeparator(this.recordDelimiter)
    +			.setColumnSeparator(this.fieldDelimiter)
    +			.setSkipFirstDataRow(skipFirstLine)
    +			.setQuoteChar(this.quoteCharacter)
    +			.setAllowComments(allowComments)
    +			.build();
    +		return  csvSchema;
    +	}
    +
    +	public OUT nextRecord(OUT reuse) throws IOException {
    +
    +		if (recordIterator == null) {
    +			return null;
    +		}
    +
    +		if (recordIterator.hasNext()) {
    +
    +			Object[] record = recordIterator.next();
    +
    +			if (record.length < fieldTypes.length) {
    +				if (isLenient()) {
    +					return nextRecord(reuse);
    +				}
    +				else {
    +					throw new ParseException();
    +				}
    +			}
    +
    +			try {
    +				return fillRecord(reuse, castRecord(projectedFields(record)));
    +			}
    +			catch (IOException e) {
    +				if (isLenient()) {
    +					return nextRecord(reuse);
    +				}
    +				else {
    +					throw new ParseException(e);
    +				}
    +			}
    +		}
    +		endOfSplit = true;
    +		return null;
    +	}
    +
    +	protected abstract OUT fillRecord(OUT reuse, Object[] parsedValues);
    +
    +	@Override
    +	public String toString() {
    +		return "CSV Input (" + StringUtils.showControlCharacters(String.valueOf(fieldDelimiter))
+ ") " + getFilePath();
    +	}
    +
    +	@Override
    +	public boolean reachedEnd() throws IOException {
    +		return endOfSplit;
    +	}
    +
    +	private Object[] projectedFields(Object[] record) throws IOException {
    +
    +		Object[] resultantRecord = new Object[fieldTypes.length];
    +		int index = 0;
    +		for (int i = 0; i < this.fieldIncluded.length; i++) {
    +
    +			try {
    +				if (fieldIncluded[i]) {
    +					resultantRecord[index++] = record[i];
    +				}
    +			}
    +			catch (Exception e) {
    +				throw new IOException();
    +			}
    +		}
    +		return resultantRecord;
    +	}
    +
    +	private long findFirstDelimiterPosition() throws IOException{
    +
    +		this.stream.seek(this.getSplitStart());
    +		if (this.stream.getPos() == 0) {
    +			return 0;
    +		}
    +		else {
    +			int pos = 1;
    +			while ((this.stream.read()) != this.recordDelimiter.charAt(0)) {
    +				pos++;
    +			}
    +			return pos;
    +		}
    +	}
    +
    +	private long findLastDelimiterPosition() throws IOException{
    +
    +		this.stream.seek(this.splitStart + this.splitLength);
    +		int pos = 0;
    +		char c;
    +		int read = this.stream.read();
    +		while (read != -1) {
    +			c = (char) read;
    +			if (c == this.recordDelimiter.charAt(0)) {
    +				break;
    +			}
    +			else {
    +				read = this.stream.read();
    +			}
    +			pos++;
    +		}
    +		return pos;
    +	}
    +
    +	private Object[] castRecord(Object[] record)  throws IOException {
    +
    +		if (isLenient()) {
    +			for (int i = 0; i < this.fieldTypes.length; i++) {
    +				try {
    +					record[i] = dataTypeConversion(record[i], fieldTypes[i]);
    +				} catch (Exception e) {
    +					throw new IOException(e);
    +				}
    +			}
    +		}
    +		else {
    +			for (int i = 0; i < this.fieldTypes.length; i++) {
    +				try {
    +					record[i] = dataTypeConversion(record[i], fieldTypes[i]);
    +				} catch (Exception e) {
    +					throw new IOException(e);
    +				}
    +			}
    +		}
    +		return record;
    +	}
    +
    +	public <I, O> O dataTypeConversion(I input, Class<O> outputClass) throws
Exception {
    --- End diff --
    
    can be `private`. Please add JavaDocs and inline comments


---

Mime
View raw message