flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...
Date Thu, 14 Sep 2017 13:32:50 GMT
Github user aljoscha commented on the issue:

    These are not actually the places where you can count dropped data. I would suggest to
add this at the very end of `processElement()` where we also check whether we should side-output
late data: https://github.com/apache/flink/blob/6642768ad8f8c5d1856742a6d148f7724c20666c/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java#L406.
    Also, I think a better metrics name would include "dropped" somehow, because right now
it just says late. Something like `numLateElementsDropped`.


View raw message