flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..."...
Date Mon, 11 Sep 2017 17:16:53 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4647#discussion_r138133763
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/MutableIOMetrics.java
---
    @@ -99,11 +140,35 @@ public void addIOMetrics(AccessExecution attempt, @Nullable MetricFetcher
fetche
     	 * @throws IOException
     	 */
     	public void writeIOMetricsAsJson(JsonGenerator gen) throws IOException {
    +		/**
    +		 * Ask describe in the addIOMetrics, we want to distinguish incomplete values from
0.
    --- End diff --
    
    typo: ask -> as
    remote "the" before addIOMetrics
    could use  ```@link annotation for the method```


---

Mime
View raw message