flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...
Date Wed, 06 Sep 2017 15:54:56 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r137270473
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -389,95 +413,332 @@ public File getFile(JobID jobId, BlobKey key) throws IOException
{
     	 *
     	 * @param jobId
     	 * 		ID of the job this blob belongs to (or <tt>null</tt> if job-unrelated)
    -	 * @param requiredBlob
    +	 * @param blobKey
     	 * 		blob key associated with the requested file
    +	 * @param highlyAvailable
    +	 * 		whether to the requested file is highly available (HA)
     	 *
     	 * @return file referring to the local storage location of the BLOB
     	 *
     	 * @throws IOException
     	 * 		Thrown if the file retrieval failed.
     	 */
    -	private File getFileInternal(@Nullable JobID jobId, BlobKey requiredBlob) throws IOException
{
    -		checkArgument(requiredBlob != null, "BLOB key cannot be null.");
    +	private File getFileInternal(@Nullable JobID jobId, BlobKey blobKey, boolean highlyAvailable)
throws IOException {
    --- End diff --
    
    Maybe we could introduce an enum here as well for the `highlyAvailable` boolean argument.


---

Mime
View raw message