flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...
Date Wed, 06 Sep 2017 09:00:45 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4645#discussion_r137209983
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
    @@ -77,14 +77,10 @@
     
     	private static final ObjectMapper objectMapper = RestMapperUtils.getStrictObjectMapper();
     
    -	// used to open connections to a rest server endpoint
    -	private final Executor executor;
    -
     	private Bootstrap bootstrap;
     
    -	public RestClient(RestClientConfiguration configuration, Executor executor) {
    +	public RestClient(RestClientConfiguration configuration) {
    --- End diff --
    
    Given that now we let netty do all the parsing, I think it makes sense to allow the user
to specify the size of the `NioEventLoopGroup ` (currently set to 1 - which can be the default).


---

Mime
View raw message