Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 7 Aug 2017 18:47:03 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13091563.1501597967000.109825.1502131623630@Atlassian.JIRA>
In-Reply-To: <JIRA.13091563.1501597967000@Atlassian.JIRA>
References: <JIRA.13091563.1501597967000@Atlassian.JIRA> <JIRA.13091563.1501597967397@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7337) Refactor handling of time indicator
 attributes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 07 Aug 2017 18:48:04 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117049#comment-16117049 ] 

ASF GitHub Bot commented on FLINK-7337:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4488#discussion_r131720129
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala ---
    @@ -148,6 +142,20 @@ class DataStreamGroupWindowAggregate(
             "state size. You may specify a retention time of 0 to not clean up the state.")
         }
     
    +    val timestampedInput = if (isRowtimeAttribute(window.timeAttribute)) {
    +      // copy the window rowtime attribute into the StreamRecord timestamp field
    +      val timeAttribute = window.timeAttribute.asInstanceOf[ResolvedFieldReference].name
    +      val timeIdx = inputSchema.logicalFieldNames.indexOf(timeAttribute)
    +
    +      inputDS
    +        .process(
    +          new TimestampSetterProcessFunction(timeIdx,CRowTypeInfo(inputSchema.physicalTypeInfo)))
    --- End diff --
    
    missing space


> Refactor handling of time indicator attributes
> ----------------------------------------------
>
>                 Key: FLINK-7337
>                 URL: https://issues.apache.org/jira/browse/FLINK-7337
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>
> After a [discussion on the dev mailing list|https://lists.apache.org/thread.html/735d55f9022df8ff73566a9f1553e14be94f8443986ad46559b35869@%3Cdev.flink.apache.org%3E] I propose the following changes to the current handling of time indicator attributes:
> * Remove the separation of logical and physical row type.
> ** Hold the event-time timestamp as regular Long field in Row
> ** Represent the processing-time indicator type as a null-valued field in Row (1 bit overhead)
> * Remove materialization of event-time timestamps because timestamp is already accessible in Row.
> * Add {{ProcessFunction}} to set timestamp into the timestamp field of a {{StreamRecord}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)