Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 10 Aug 2017 09:28:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13087299.1500065660000.136432.1502357281244@Atlassian.JIRA>
In-Reply-To: <JIRA.13087299.1500065660000@Atlassian.JIRA>
References: <JIRA.13087299.1500065660000@Atlassian.JIRA> <JIRA.13087299.1500065660795@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7199) Graph simplification does not set
 parallelism
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 10 Aug 2017 09:28:09 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121349#comment-16121349 ] 

ASF GitHub Bot commented on FLINK-7199:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4346#discussion_r132400768
  
    --- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/EdgeListITCase.java ---
    @@ -56,214 +56,304 @@ public void testLongDescription() throws Exception {
     			ProgramParametrizationException.class);
     	}
     
    +	// CirculantGraph
    +
    +	private String[] getCirculantGraphParamters(String output) {
    +		return parameters("CirculantGraph", output, "--vertex_count", "42", "--range0", "13:4");
    +	}
    +
     	@Test
     	public void testHashWithCirculantGraph() throws Exception {
    -		expectedChecksum(
    -			parameters("CirculantGraph", "hash", "--vertex_count", "42", "--range0", "13:4"),
    -			168, 0x000000000001ae80);
    +		expectedChecksum(getCirculantGraphParamters("hash"), 168, 0x000000000001ae80);
     	}
     
     	@Test
     	public void testPrintWithCirculantGraph() throws Exception {
     		// skip 'char' since it is not printed as a number
     		Assume.assumeFalse(idType.equals("char") || idType.equals("nativeChar"));
     
    -		expectedOutputChecksum(
    -			parameters("CirculantGraph", "print", "--vertex_count", "42", "--range0", "13:4"),
    -			new Checksum(168, 0x0000004bdcc52cbcL));
    +		expectedOutputChecksum(getCirculantGraphParamters("print"), new Checksum(168, 0x0000004bdcc52cbcL));
    +	}
    +
    +	@Test
    +	public void testParallelismWithCirculantGraph() throws Exception {
    +		TestUtils.verifyParallelism(getCirculantGraphParamters("print"));
    +	}
    +
    +	// CompleteGraph
    +
    +	private String[] getCompleteGraphParamters(String output) {
    --- End diff --
    
    typo, should be: `getCompleteGraphParameters`


> Graph simplification does not set parallelism
> ---------------------------------------------
>
>                 Key: FLINK-7199
>                 URL: https://issues.apache.org/jira/browse/FLINK-7199
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The {{Simplify}} parameter should accept and set the parallelism when calling the {{Simplify}} algorithms.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)