Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 16 Aug 2017 16:46:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13083811.1498834314000.45174.1502901960229@Atlassian.JIRA>
In-Reply-To: <JIRA.13083811.1498834314000@Atlassian.JIRA>
References: <JIRA.13083811.1498834314000@Atlassian.JIRA> <JIRA.13083811.1498834314759@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7057) move BLOB ref-counting from
 LibraryCacheManager to BlobCache
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 16 Aug 2017 16:46:13 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129054#comment-16129054 ] 

ASF GitHub Bot commented on FLINK-7057:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4238#discussion_r133500735
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/JobManagerConnection.java ---
    @@ -63,21 +67,22 @@
     	private final PartitionProducerStateChecker partitionStateChecker;
     
     	public JobManagerConnection(
    -		JobID jobID,
    -		ResourceID resourceID,
    -		JobMasterGateway jobMasterGateway,
    -		UUID leaderId,
    -		TaskManagerActions taskManagerActions,
    -		CheckpointResponder checkpointResponder,
    -		LibraryCacheManager libraryCacheManager,
    -		ResultPartitionConsumableNotifier resultPartitionConsumableNotifier,
    -		PartitionProducerStateChecker partitionStateChecker) {
    +			JobID jobID,
    +			ResourceID resourceID,
    +			JobMasterGateway jobMasterGateway,
    +			UUID leaderId,
    +			TaskManagerActions taskManagerActions,
    +			CheckpointResponder checkpointResponder,
    +			BlobCache blobCache, LibraryCacheManager libraryCacheManager,
    --- End diff --
    
    Formatting


> move BLOB ref-counting from LibraryCacheManager to BlobCache
> ------------------------------------------------------------
>
>                 Key: FLINK-7057
>                 URL: https://issues.apache.org/jira/browse/FLINK-7057
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> Currently, the {{LibraryCacheManager}} is doing some ref-counting for JAR files managed by it. Instead, we want the {{BlobCache}} to do that itself for all job-related BLOBs. Also, we do not want to operate on a per-{{BlobKey}} level but rather per job. Therefore, the cleanup process should be adapted, too.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)