Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: kaibozhou <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4355-flink@git.apache.org>
In-Reply-To: <git-pr-4355-flink@git.apache.org>
Subject: [GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...
Content-Type: text/plain
Message-Id: <20170825042500.0275FF5658@git1-us-west.apache.org>
Date: Fri, 25 Aug 2017 04:25:00 +0000 (UTC)
archived-at: Fri, 25 Aug 2017 04:25:04 -0000

Github user kaibozhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135181433
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala ---
    @@ -100,6 +108,17 @@ abstract class GeneratedAggregations extends Function {
         *                     aggregated results
         */
       def resetAccumulator(accumulators: Row)
    +
    +  /**
    +    * Cleanup for the accumulators.
    +    */
    +  def cleanup()
    +
    +  /**
    +    * Tear-down method for [[org.apache.flink.table.functions.AggregateFunction]].
    +    * It can be used for clean up work. By default, this method does nothing.
    +    */
    +  def close()
    --- End diff --
    
    The close() method is corresponding to open method. And it will be called when open was called before, e.g. ProcTimeUnboundedOver's close() method. Otherwise, the udagg's close will not be called. 
    
    I modify the case testGroupAggregateWithStateBackend to test the close was called.
    
    what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---