Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: kaibozhou <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4355-flink@git.apache.org>
In-Reply-To: <git-pr-4355-flink@git.apache.org>
Subject: [GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...
Content-Type: text/plain
Message-Id: <20170825034811.4CD02DFA24@git1-us-west.apache.org>
Date: Fri, 25 Aug 2017 03:48:11 +0000 (UTC)
archived-at: Fri, 25 Aug 2017 03:48:15 -0000

Github user kaibozhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135179101
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala ---
    @@ -178,13 +294,15 @@ class AggregationCodeGenerator(
                    |      ${aggMapping(i)},
                    |      (${accTypes(i)}) accs.getField($i));""".stripMargin
               } else {
    +            val setDataView = genDataViewFieldSetter(s"acc$i", i)
                 j"""
                    |    org.apache.flink.table.functions.AggregateFunction baseClass$i =
                    |      (org.apache.flink.table.functions.AggregateFunction) ${aggs(i)};
    -               |
    +               |    ${accTypes(i)} acc$i = (${accTypes(i)}) accs.getField($i);
    +               |    $setDataView
    --- End diff --
    
    yes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---