Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DC5B7200CE7 for ; Fri, 18 Aug 2017 07:01:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DABD116986A; Fri, 18 Aug 2017 05:01:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2E3A8169850 for ; Fri, 18 Aug 2017 07:01:48 +0200 (CEST) Received: (qmail 43631 invoked by uid 500); 18 Aug 2017 05:01:47 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 43622 invoked by uid 99); 18 Aug 2017 05:01:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 05:01:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C5281C0334 for ; Fri, 18 Aug 2017 05:01:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fk-QOuvAsa8I for ; Fri, 18 Aug 2017 05:01:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1E1735F523 for ; Fri, 18 Aug 2017 05:01:44 +0000 (UTC) Received: (qmail 43604 invoked by uid 99); 18 Aug 2017 05:01:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 05:01:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7FD81DFF9F; Fri, 18 Aug 2017 05:01:43 +0000 (UTC) From: tzulitai To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF... Content-Type: text/plain Message-Id: <20170818050143.7FD81DFF9F@git1-us-west.apache.org> Date: Fri, 18 Aug 2017 05:01:43 +0000 (UTC) archived-at: Fri, 18 Aug 2017 05:01:49 -0000 Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4557 This LGTM, +1. Merging this .. Minor nitpick for the future: I think although this is a small fix, the nature of the fix still deserves a dedicated JIRA ticket for it. Hotfixes, AFAIK, are meant only for minor cosmetic refactorings or typos. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---