Return-Path: <issues-return-126533-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id A419420049D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  9 Aug 2017 15:02:56 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id A28BE16918E; Wed,  9 Aug 2017 13:02:56 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E8EF716918C
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  9 Aug 2017 15:02:55 +0200 (CEST)
Received: (qmail 59174 invoked by uid 500); 9 Aug 2017 13:02:55 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 59165 invoked by uid 99); 9 Aug 2017 13:02:55 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 13:02:55 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B1A87C4120
	for <issues@flink.apache.org>; Wed,  9 Aug 2017 13:02:54 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id 6OFvQwyhffNk for <issues@flink.apache.org>;
	Wed,  9 Aug 2017 13:02:54 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id A7B435FD47
	for <issues@flink.incubator.apache.org>; Wed,  9 Aug 2017 13:02:53 +0000 (UTC)
Received: (qmail 59154 invoked by uid 99); 9 Aug 2017 13:02:53 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 13:02:53 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1F5B1DF9AB; Wed,  9 Aug 2017 13:02:53 +0000 (UTC)
From: dawidwys <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4331-flink@git.apache.org>
In-Reply-To: <git-pr-4331-flink@git.apache.org>
Subject: [GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...
Content-Type: text/plain
Message-Id: <20170809130253.1F5B1DF9AB@git1-us-west.apache.org>
Date: Wed,  9 Aug 2017 13:02:53 +0000 (UTC)
archived-at: Wed, 09 Aug 2017 13:02:56 -0000

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4331#discussion_r132139143
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -322,6 +336,64 @@ public void resetNFAChanged() {
     
     		}
     
    +		Set<T> discardEvents = new HashSet<>();
    +		switch(afterMatchSkipStrategy.getStrategy()) {
    +			case SKIP_TO_LAST:
    +				for (Map<String, List<T>> resultMap: result) {
    +					boolean matched = false;
    +					for (String key: resultMap.keySet()) {
    +						if (key.equals(afterMatchSkipStrategy.getPatternName())) {
    +							matched = true;
    +							discardEvents.addAll(resultMap.get(key).subList(0, resultMap.get(key).size() - 1));
    +						} else if (!matched) {
    +							discardEvents.addAll(resultMap.get(key));
    +						}
    +					}
    +				}
    +				break;
    +			case SKIP_TO_FIRST:
    +				for (Map<String, List<T>> resultMap: result) {
    --- End diff --
    
    similar as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---