Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4492-flink@git.apache.org>
In-Reply-To: <git-pr-4492-flink@git.apache.org>
Subject: [GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...
Content-Type: text/plain
Message-Id: <20170809101726.85248DFF73@git1-us-west.apache.org>
Date: Wed,  9 Aug 2017 10:17:26 +0000 (UTC)
archived-at: Wed, 09 Aug 2017 10:17:32 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4492#discussion_r132143993
  
    --- Diff: docs/setup/config.md ---
    @@ -389,6 +389,10 @@ These parameters allow for advanced tuning. The default values are sufficient wh
     
     - `jobmanager.web.access-control-allow-origin`: Enable custom access control parameter for allow origin header, default is `*`.
     
    +### Web Frontend
    --- End diff --
    
    I think that having some options tied to the jobmanager while others aren't will just cause more work down the line. Either add it the the jobmanager options now and move it in a follow-up, or separate the options now and rebase the PR on top of it.
    
    The "let's refactor the rest later" mentality just doesn't work for us, see the translation to ConfigOptions which _still isn't done_.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---