Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A1C16200CED for ; Fri, 4 Aug 2017 04:32:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A06E116CF2B; Fri, 4 Aug 2017 02:32:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E5CE016CF29 for ; Fri, 4 Aug 2017 04:32:11 +0200 (CEST) Received: (qmail 51201 invoked by uid 500); 4 Aug 2017 02:32:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 51192 invoked by uid 99); 4 Aug 2017 02:32:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 02:32:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 98769C040F for ; Fri, 4 Aug 2017 02:32:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id e-H3lyZaA1BM for ; Fri, 4 Aug 2017 02:32:09 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 2DF585F5B3 for ; Fri, 4 Aug 2017 02:32:09 +0000 (UTC) Received: (qmail 51164 invoked by uid 99); 4 Aug 2017 02:32:08 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 02:32:08 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 33EF0F3263; Fri, 4 Aug 2017 02:32:08 +0000 (UTC) From: tzulitai To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper... Content-Type: text/plain Message-Id: <20170804023208.33EF0F3263@git1-us-west.apache.org> Date: Fri, 4 Aug 2017 02:32:08 +0000 (UTC) archived-at: Fri, 04 Aug 2017 02:32:12 -0000 Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4328 Thanks for that @zhangminglei. However, I've already finished testing a batch of commits with this fix included, and would like to merge that now. Sometimes I collect a batch of commits and run them on Travis before merging (that's why it isn't actually merged yet). It's safe to leave some final minor cosmetic fix to the person merging the PR if they mentioned they'll fix it when merging. That'll also avoid duplicate work and wasted efforts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---