flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bbayani <...@git.apache.org>
Subject [GitHub] flink pull request #4622: [FLINK-7294]:[flink-mesos] mesos.resourcemanager.f...
Date Wed, 30 Aug 2017 10:23:28 GMT
GitHub user bbayani opened a pull request:


    [FLINK-7294]:[flink-mesos] mesos.resourcemanager.framework.role not working

    Jira Issue: FLINK-7294
    ## What is the purpose of the change
    This pull request uses role set in mesos.resourcemanager.framework.role and applies it
for resources such as CPU, mem, ports.  Due to this framework considers resource offers coming
from mesos-agents with specified role and is able to spawn up task-managers on mesos-agent
running with specific role that role *. 
    ## Brief change log
      - Updated Utils.java to take in role information for constructing scalar / ranges resource
      - Updated LaunchableMesosWorker to use framework role set in config.
      - Updated tests in LaunchCoordinatorTest.scala to pass role argument.
    ## Verifying this change
    Part of change is already covered by existing tests, such as  LaunchCoordinatorTest.scala.
    Also, manually verified the change by running a flink-mesos cluster with 1 job-manager
and 3 task-managers. The flink was deployed on a mesos-cluster where mesos-workers were running
with specific role and not role '*'.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency):  no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
      - The serializers: no 
      - The runtime per-record code paths (performance sensitive): no 
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: yes, it affects deployment on Mesos.
    ## Documentation
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not documented
    @EronWright : PTAL. Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbayani/flink mesos_role_issue

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4622
commit 883c3866302b8073b60403b65c3aac85759b891c
Author: bbayani <bbayani@cisco.com>
Date:   2017-08-30T09:54:54Z

    [FLINK-7294]:mesos.resourcemanager.framework.role not working


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message