flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / ...
Date Tue, 29 Aug 2017 13:59:51 GMT
GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4616

    [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in FlinkKafkaProducer

    ## What is the purpose of the change
    
    Enhance `SinkFunction` with a way of retrieving the element timestamp. This allows us
to get rid of the hybrid nature of `FlinkKafkaProducer010`.
    
    This is keeping the legacy static "convenience" methods à la `FlinkKafkaProducer010.writeToKafkaWithTimestamps`
for backwards compatibility.
    
    ## Brief change log
    
      - Enhance Sink interface
      - Use new interface in Kafka Producer
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): yes, call stack of KafkaProducer
with writing timestamps is changed slightly, also, `StreamSink` operator now has a context
object.
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-7553-fix-kafka010-producer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4616
    
----
commit 0b5bea36247736a0160ce584b94050d7b676d091
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-08-29T13:50:56Z

    [FLINK-7552] Extend SinkFunction interface with SinkContext

commit d3a7b294542ea40287290ff4970715ead621d398
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-08-29T13:53:16Z

    [FLINK-7553] Use new SinkFunction interface in FlinkKafkaProducer010

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message