flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerIT...
Date Fri, 25 Aug 2017 12:31:04 GMT
GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4591

    [FLINK-7514][tests] fix BackPressureStatsTrackerITCase releasing buffers twice

    ## What is the purpose of the change
    
    `BackPressureStatsTrackerITCase#testBackPressuredProducer()` is releasing its buffers
twice which is fixed by this PR while making sure they are actually released.
    
    ## Brief change log
    
    - remove duplicate `buf.recycle()`
    - ensure buffers are released when expected
    
    ## Verifying this change
    
    This change is part of the `BackPressureStatsTrackerITCase` test.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7514

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4591
    
----
commit c889a8e387ebdaff7dcc1f967e4439586855a6b3
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-08-25T07:49:44Z

    [FLINK-7514][tests] fix BackPressureStatsTrackerITCase releasing buffers twice

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message