flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7563) Fix watermark semantics in CEP operators
Date Thu, 31 Aug 2017 21:16:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149615#comment-16149615

ASF GitHub Bot commented on FLINK-7563:

GitHub user yestinchen opened a pull request:


    [FLINK-7563] [cep] Fix watermark semantics in cep and related tests.

    ## What is the purpose of the change
    Correct the watermark semantics in cep.
    ## Brief change log
    -  use the logic that (timestamp <= watermark) is considered late.
    ## Verifying this change
    *(Please pick either of the following options)*
    This change is already covered by existing tests, such as `testCEPOperatorCleanupEventTime()`,
and `testCEPOperatorSerializationWRocksDB()` in `CEPOperatorTest.java`
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yestinchen/flink FLINK-7563

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4632
commit 419921c81be20b0c00dfeaba287f603af2600fad
Author: Yestin <873915231@qq.com>
Date:   2017-08-31T21:09:30Z

    [FLINK-7563] [cep] Fix watermark semantics in cep and related tests.


> Fix watermark semantics in CEP operators
> ----------------------------------------
>                 Key: FLINK-7563
>                 URL: https://issues.apache.org/jira/browse/FLINK-7563
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>            Reporter: Aljoscha Krettek
>            Assignee: Yueting Chen
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.3
> See https://lists.apache.org/thread.html/3541e72ba3842192e58a487e54c2817f6b2b9d12af5fee97af83e5df@%3Cdev.flink.apache.org%3E
for reference.

This message was sent by Atlassian JIRA

View raw message