flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction
Date Fri, 18 Aug 2017 08:39:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131907#comment-16131907
] 

ASF GitHub Bot commented on FLINK-7476:
---------------------------------------

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4561

     [FLINK-7476][streaming] Continue using previous transaction on failures

    First commit comes from #4557.
    
    Previously when using TwoPhaseCommitSinkFunction, if there was some intermittent failure
in "beginTransaction", not only the snapshot that triggered this call failed, but also any
subsequent write requests would fail also. This caused such sink unusable until application
restart.
    
    This PR changes order of execution of the methods from `PublicEvolving` class that has
not been yet released.
    
    PR is covered by existing tests in `TwoPhaseCommitSinkFunctionTest` as well as two additional
test cases (`testContinueWorkOnBeginTransactionFailure` would be failing before this PR).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink 2phase-recover

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4561
    
----
commit 813c8121b406b60ea478f4765b33b7d75c221d1e
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-08-14T14:40:45Z

    [hotifx][streaming] Simplify state of TwoPhaseCommitSinkFunction

commit 249b6419af3d15414dc411838aba624d0ee2f3a1
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-08-14T13:09:39Z

    [hotfix][tests] Implement AutoCloseable in TestHarness

commit a0ae6324dcaded581a3352c8ff4bae6e86e01fde
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-08-17T13:46:47Z

    [hotfix][streaming] Refactor TwoPhaseCommitSinkFunctionTest

commit e3c7dc83ccbce2505be5769fa0827b09dfa54875
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-08-17T10:29:16Z

    [FLINK-7476][streaming] Continue using previous transaction on failures
    
    Previuosly when using TwoPhaseCommitSinkFunction, if there was some intermittent failure
    in "beginTransaction", not only the snapshot that triggered this call failed, but also
    any subsequent write requests would fail also. This caused such sink unusable until
    application restart.

----


> Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction
> --------------------------------------------------------------------------
>
>                 Key: FLINK-7476
>                 URL: https://issues.apache.org/jira/browse/FLINK-7476
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.4.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.4.0
>
>
> Currently when using TwoPhaseCommitSinkFunction, if there is some intermittent failure
in "beginTransaction", not only the snapshot that triggered this call fail, but also any subsequent
write requests will fail also, rendering such sink unusable until application restart.
> This issue is in code that hasn't been released yet.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message