flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7444) Make external calls non-blocking
Date Mon, 14 Aug 2017 12:53:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125629#comment-16125629

ASF GitHub Bot commented on FLINK-7444:

GitHub user tillrohrmann opened a pull request:


    [FLINK-7444] [rpc] Make external calls non-blocking

    ## What is the purpose of the change
    Make all external calls from the RpcEndpoint's main thread non blocking by
    executing them as a runnable in an Executor.
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink makeEndpointsNonBlocking

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4540
commit ccaabc5c54fb91bdbadbc22191565e308c0f4c1b
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-08-14T12:48:33Z

    [FLINK-7444] [rpc] Make external calls non-blocking
    Make all external calls from the RpcEndpoint's main thread non blocking by
    executing them as a runnable in an Executor.


> Make external calls non-blocking
> --------------------------------
>                 Key: FLINK-7444
>                 URL: https://issues.apache.org/jira/browse/FLINK-7444
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
> All external calls from a {{RpcEndpoint}} can be potentially blocking, e.g. calls to
the {{FatalErrorHandler}}. Therefore, I propose to make all these calls coming from the {{RpcEndpoint's}}
main thread non-blocking by running them in an {{Executor}}. That way the main thread will
never be blocked.

This message was sent by Atlassian JIRA

View raw message