flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7399) Add checkstyle rule to forbid codehaus jackson imports
Date Wed, 09 Aug 2017 13:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119895#comment-16119895
] 

ASF GitHub Bot commented on FLINK-7399:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4505

    [FLINK-7399] [checkstyle] Forbid imports from org.codehaus.jackson

    ## What is the purpose of the change
    
    Flink uses `com.fasterxml.jackson` but pulls in the codehaus version from various dependencies.
This PR forbids using the codehaus version using checkstyle.
    
    
    ## Brief change log
    
    *(for example:)*
      - Add `org.codehaus.jackson` to the list of illegal packages of the `IllegalImport`
module
    
    
    ## Verifying this change
    
    1) Run `mvn checkstyle:check`, it should not fail.
    2) Add some import from `org.codehaus.jackson`, running checkstyle should now fail,


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7399

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4505
    
----

----


> Add checkstyle rule to forbid codehaus jackson imports
> ------------------------------------------------------
>
>                 Key: FLINK-7399
>                 URL: https://issues.apache.org/jira/browse/FLINK-7399
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message