flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes
Date Mon, 07 Aug 2017 18:47:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117040#comment-16117040
] 

ASF GitHub Bot commented on FLINK-7337:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4488#discussion_r131708260
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -245,14 +244,18 @@ abstract class CodeGenerator(
           returnType: TypeInformation[_ <: Any],
           resultFieldNames: Seq[String])
         : GeneratedExpression = {
    -    val input1AccessExprs = input1Mapping.map { idx =>
    -      generateInputAccess(input1, input1Term, idx)
    +    val input1AccessExprs = input1Mapping.map {
    --- End diff --
    
    Please add some inline comments here and also in the ScalaDoc of `input1Mapping` and `input2Mapping`.


> Refactor handling of time indicator attributes
> ----------------------------------------------
>
>                 Key: FLINK-7337
>                 URL: https://issues.apache.org/jira/browse/FLINK-7337
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>
> After a [discussion on the dev mailing list|https://lists.apache.org/thread.html/735d55f9022df8ff73566a9f1553e14be94f8443986ad46559b35869@%3Cdev.flink.apache.org%3E]
I propose the following changes to the current handling of time indicator attributes:
> * Remove the separation of logical and physical row type.
> ** Hold the event-time timestamp as regular Long field in Row
> ** Represent the processing-time indicator type as a null-valued field in Row (1 bit
overhead)
> * Remove materialization of event-time timestamps because timestamp is already accessible
in Row.
> * Add {{ProcessFunction}} to set timestamp into the timestamp field of a {{StreamRecord}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message