flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7312) activate checkstyle for flink/core/memory/*
Date Tue, 01 Aug 2017 14:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108957#comment-16108957
] 

ASF GitHub Bot commented on FLINK-7312:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    If the tooling is hard to be made to cooperate, then I am not religious about the `final`
keyword here.
    
    This is more of a general theme: I am trying to advocate to not change things "just because
it looks better". 
    Once you did your first set of late night debugging sessions and found that the bug was
introduced by a "cleanup" change, you may know why I feel quite strongly about this...


> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>
>                 Key: FLINK-7312
>                 URL: https://issues.apache.org/jira/browse/FLINK-7312
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle, Core
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message