flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7311) refrain from using fail(Exception#getMessage()) in core memory tests
Date Wed, 02 Aug 2017 09:17:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110597#comment-16110597
] 

ASF GitHub Bot commented on FLINK-7311:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4446
  
    If FLINK-7310 also cleanly applies to FLINK-7311 as well, i would say yes. If not it's
up to you whether you want to invest the time for a rebase.


> refrain from using fail(Exception#getMessage()) in core memory tests
> --------------------------------------------------------------------
>
>                 Key: FLINK-7311
>                 URL: https://issues.apache.org/jira/browse/FLINK-7311
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Tests
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> Most unit tests in the {{flink/core/memory/}} domain still relies on a code pattern like
this:
> {code}
> try {
> 	// ...
> } catch (Exception e) {
> 	e.printStackTrace();
> 	fail(e.getMessage());
> }
> {code}
> This does hides the exception details and should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message