flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Wed, 23 Aug 2017 04:19:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137857#comment-16137857
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user kaibozhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r134653928
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -1646,4 +1649,86 @@ abstract class CodeGenerator(
     
         fieldTerm
       }
    +
    +  /**
    +    * Adds a reusable class to the member area of the generated [[Function]].
    +    */
    +  def addReusableClass(clazz: Class[_], fieldTerm: String): Unit = {
    +    val field =
    +      s"""
    +         |transient ${clazz.getCanonicalName} $fieldTerm = null;
    +         |""".stripMargin
    +    reusableMemberStatements.add(field)
    +  }
    +
    +  /**
    +    * Adds a reusable [[DataViewConfig]] to the member area of the generated [[Function]].
    +    *
    +    * @param indices indices of aggregate functions.
    +    * @param ctxTerm field name of runtime context.
    +    * @param accConfig data view config which contains id, field and StateDescriptos.
    +    * @return statements to create [[MapView]] or [[ListView]].
    +    */
    +  def addReusableDataViewConfig(
    --- End diff --
    
    Its a good idea, the code will be more clean after refactor.


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message